Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert IMessagePackConverter to an abstract base class #249

Merged
merged 2 commits into from
Feb 1, 2025
Merged

Conversation

AArnott
Copy link
Owner

@AArnott AArnott commented Feb 1, 2025

No description provided.

Copy link

codecov bot commented Feb 1, 2025

Codecov Report

Attention: Patch coverage is 95.91837% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.41%. Comparing base (afc5e8e) to head (7cc974d).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
....MessagePack/Converters/SubTypeUnionConverter`1.cs 85.71% 1 Missing ⚠️
src/Nerdbank.MessagePack/MessagePackConverter`1.cs 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #249      +/-   ##
==========================================
- Coverage   84.44%   84.41%   -0.03%     
==========================================
  Files         167      167              
  Lines       13511    13514       +3     
  Branches     1451     1452       +1     
==========================================
- Hits        11409    11408       -1     
- Misses       2074     2079       +5     
+ Partials       28       27       -1     
Flag Coverage Δ
Linux 82.71% <93.87%> (-0.01%) ⬇️
Windows 84.40% <95.91%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AArnott AArnott merged commit 0443b0b into main Feb 1, 2025
4 checks passed
@AArnott AArnott deleted the fix246 branch February 1, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change enhancement New feature or request
Projects
None yet
1 participant